Test Diagonal functions against non-dense matrices #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
- Coverage 93.72% 93.71% -0.02%
==========================================
Files 34 34
Lines 15733 15733
==========================================
- Hits 14746 14744 -2
- Misses 987 989 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Diagonaltests, we often compare results of function evaluations with that for the corresponding dense matrix. E.g., withD = Diagonal(::Vector)andDM = Matrix(D),The problem with this is that, in the dense method
log(::Matrix), we check if the matrix is diagonal, and dispatch to theDiagonalmethods for performance. This makes this test useless, as we are comparing identical methods.In this PR, I've changed the type of
DMto beHermitianfor real matrices, andUpperTriangularfor complex ones. Both of these types have special methods forlog, at least. TheHermitianmatrices have special methods for all the trigonometric functions, and for the complex matrices, we wrap these in a custom wrapperNotDiagonalthat avoids theisdiagpaths. This wrapper lies about the structure, but it should be ok for the testing purposes as we ensure that we are comparing different paths.